Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump weatherflow4py to 0.1.17 #112661

Merged
merged 2 commits into from Mar 12, 2024
Merged

Bump weatherflow4py to 0.1.17 #112661

merged 2 commits into from Mar 12, 2024

Conversation

jeeftor
Copy link
Contributor

@jeeftor jeeftor commented Mar 7, 2024

Breaking change

Proposed change

Its snowing and snow_likely was missing from backing lib

image

jeeftor/weatherflow4py@v0.1.14...v0.1.17

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title WeatherFlow Cloud - Backing Lib bump (Snow Likely) Bump weatherflow4py to 0.1.17 Mar 8, 2024
Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR and the library diff look fine.

The PR description suggests that this will fix #112785, but I couldn't see how as that issue relates to 'moderate rain' and the only library changes in the PR seem to be about 'extreme rain'.

@frenck frenck added this to the 2024.3.1 milestone Mar 12, 2024
@frenck frenck merged commit 8480128 into home-assistant:dev Mar 12, 2024
53 checks passed
frenck pushed a commit that referenced this pull request Mar 13, 2024
@frenck frenck mentioned this pull request Mar 13, 2024
xeniter pushed a commit to xeniter/core that referenced this pull request Mar 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants