Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SSDP tasks background HassJob to avoid delaying startup #112668

Merged
merged 7 commits into from Mar 9, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 8, 2024

Proposed change

Make SSDP HassJob background tasks to avoid delaying startup

Because the callback function is a coro, some of the consumers would suspend in the coro which would delay additional callbacks from being fired. We now run the callbacks as eager background HassJob so the next one is not delayed if another callback has to suspend and await.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Copy link
Member Author

bdraco commented Mar 8, 2024

Guess we need a way to block on background tasks in tests

@bdraco
Copy link
Member Author

bdraco commented Mar 8, 2024

I'll split this into another PR if the CI passes.

There are a lot of places we need to convert to background tasks so its going to be more useful elsewhere

@bdraco
Copy link
Member Author

bdraco commented Mar 9, 2024

I ended up collapsing #112549 into this PR since they are effectively solving the same/similar issues

@bdraco bdraco changed the title Make SSDP tasks background tasks to avoid delaying startup Make SSDP tasks background HassJob to avoid delaying startup Mar 9, 2024
@bdraco bdraco marked this pull request as ready for review March 9, 2024 09:10
@bdraco bdraco merged commit 2b0b3c2 into dev Mar 9, 2024
35 checks passed
@bdraco bdraco deleted the ssdp_lookups_background branch March 9, 2024 09:11
@bdraco bdraco mentioned this pull request Mar 9, 2024
20 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants