Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local calendar handling of empty recurrence ids #112745

Merged
merged 2 commits into from Mar 9, 2024

Conversation

allenporter
Copy link
Contributor

Proposed change

Fix bug when editing or deleting existing calendar events which fails with:

Error handling Calendar Event call: Unable to parse date/time value: [ValueError("Expected value to match DATE pattern: ''"), ValueError('Expected value to match DATE-TIME pattern: ')]

The frontend currently passes in an empty string for the recurrence_id which is then attempted to be parsed as an event id instance. This fixes the schema parser to ignore empty strings and treat them as none.

Alternatives:

  • An alternative could be to patch ical to handle this, but I like the idea of passing None explicitly into the entity APIs.
  • Another alternative could be to fix the frontend to omit the recurrence id but I leaned towards this to just keep the code as defensive

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Mar 8, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (calendar) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of calendar can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign calendar Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@allenporter allenporter added this to the 2024.3.1 milestone Mar 8, 2024
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works.

I think that we might want to teach the frontend to sent in None instead of empty strings too.

@balloob balloob merged commit 2789060 into home-assistant:dev Mar 9, 2024
35 checks passed
@UK-JustinSmall
Copy link

OK can someone please let me know what I need to do to get this fixed in home assistant? Seems ticket got marked as fixed but problem still appears in mine.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local Calendar can't edit or delete
4 participants