Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MJPEG fallback when still image URL is missing with basic auth #112861

Merged
merged 4 commits into from Mar 10, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 10, 2024

Proposed change

I bought an old DCS-930L (circa 2010) camera on ebay to test with

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I picked up an old DCS-930L (circa 2010) camera to test with
to fix #94877
@home-assistant home-assistant bot added cla-signed integration: mjpeg small-pr PRs with less than 30 lines. labels Mar 10, 2024
@bdraco bdraco added this to the 2024.3.1 milestone Mar 10, 2024
I picked up an old DCS-930L (circa 2010) camera to test with
to fix #94877
I picked up an old DCS-930L (circa 2010) camera to test with
to fix #94877
I picked up an old DCS-930L (circa 2010) camera to test with
to fix #94877
@balloob balloob merged commit 0ad14da into dev Mar 10, 2024
35 checks passed
@balloob balloob deleted the mjpeg_image_fallback_basic_auth_fix branch March 10, 2024 04:02
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MJPEG IP Camera broke in 2023.6
3 participants