Fix availability for GIOS index sensors #113021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
has-tests
integration: gios
small-pr
balloob
reviewed
Mar 11, 2024
| sensor_data = getattr(self.coordinator.data, self.entity_description.key) | ||
| available = super().available and bool(sensor_data) |
There was a problem hiding this comment.
bool(sensor_data) will be False if the value is 0. Should you check against None instead ?
There was a problem hiding this comment.
sensor_data could be a Sensor object or None, it couldn't be 0 https://github.com/bieniu/gios/blob/d836f0c048bf2eb2847559467c5b05f264c42641/gios/model.py#L20
balloob
reviewed
Mar 11, 2024
|
|
||
| # Sometimes the API returns sensor data without indexes | ||
| if self.entity_description.subkey: | ||
| if self.entity_description.subkey and available: | ||
| return available and bool(sensor_data.index) |
There was a problem hiding this comment.
index is a non-empty string (good, very_good, moderate, etc.) or None https://github.com/bieniu/gios/blob/d836f0c048bf2eb2847559467c5b05f264c42641/gios/model.py#L12
frenck
added
the
smash
balloob
approved these changes
Mar 12, 2024
|
Thanks! :) |
frenck
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Fix availability for index sensors * Improve test_availability() --------- Co-authored-by: Maciej Bieniek <478555+bieniu@users.noreply.github.com>
Merged
xeniter
pushed a commit
to xeniter/core
that referenced
this pull request
Mar 13, 2024
* Fix availability for index sensors * Improve test_availability() --------- Co-authored-by: Maciej Bieniek <478555+bieniu@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Improves availability to avoid
AttributeErrorwhen measurement station suddenly does not return data for one sensor.Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: