Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostics for IPP #113205

Merged
merged 6 commits into from Mar 14, 2024
Merged

Add diagnostics for IPP #113205

merged 6 commits into from Mar 14, 2024

Conversation

ctalkington
Copy link
Contributor

@ctalkington ctalkington commented Mar 13, 2024

Proposed change

Depends on #113204

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@ctalkington ctalkington marked this pull request as ready for review March 13, 2024 23:02
@joostlek joostlek added this to the 2024.3.2 milestone Mar 13, 2024
@joostlek
Copy link
Member

Might as well include it in the patch release for better debugging

@ctalkington ctalkington merged commit fe99d80 into dev Mar 14, 2024
21 checks passed
@ctalkington ctalkington deleted the ctalkington-ipp-diag branch March 14, 2024 05:44
@frenck frenck modified the milestones: 2024.3.2, 2024.3.1 Mar 14, 2024
frenck pushed a commit that referenced this pull request Mar 14, 2024
@frenck frenck mentioned this pull request Mar 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants