New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snmp: Better sensor support to resolve previous issues #113624
Conversation
Also added test cases for String, Integer and Real types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Thank you for your contribution thus far! 🎖 Since this is a significant contribution, we would appreciate you'd added yourself to the list of code owners for this integration. ❤️ Please, add your GitHub username to the For more information about "code owners", see: Architecture Decision Record 0008: Code owners. |
Please do so in a new Pull Request. The advantage being, that you get notified automatically on new issues, which of course is interesting presuming you use the integration. |
@bdraco Thanks for the advice, but like you might discover the changes were made by @ChristianKuehnel, not us. Our team will keep an eye on HA SNMP related features from time to time and provide support if possible as upstream component ( |
Breaking change
Proposed change
We picked up the work done by @ChristianKuehnel in #11239 and added simpler test cases for review.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: