Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snmp: Better sensor support to resolve previous issues #113624

Merged
merged 12 commits into from Mar 16, 2024

Conversation

lextm
Copy link
Contributor

@lextm lextm commented Mar 16, 2024

Breaking change

Proposed change

We picked up the work done by @ChristianKuehnel in #11239 and added simpler test cases for review.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@janiversen janiversen changed the title Better sensor support to resolve previous issues snap: Better sensor support to resolve previous issues Mar 16, 2024
@janiversen janiversen changed the title snap: Better sensor support to resolve previous issues snmp: Better sensor support to resolve previous issues Mar 16, 2024
Copy link
Member

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@bdraco
Copy link
Member

bdraco commented Mar 16, 2024

Thank you for your contribution thus far! 🎖 Since this is a significant contribution, we would appreciate you'd added yourself to the list of code owners for this integration. ❤️

Please, add your GitHub username to the manifest.json of this integration.

For more information about "code owners", see: Architecture Decision Record 0008: Code owners.

@janiversen janiversen merged commit 2bc4a50 into home-assistant:dev Mar 16, 2024
21 checks passed
@janiversen
Copy link
Member

Please do so in a new Pull Request.

The advantage being, that you get notified automatically on new issues, which of course is interesting presuming you use the integration.

@lextm
Copy link
Contributor Author

lextm commented Mar 16, 2024

@bdraco Thanks for the advice, but like you might discover the changes were made by @ChristianKuehnel, not us.

Our team will keep an eye on HA SNMP related features from time to time and provide support if possible as upstream component (pysnmp-lextudio) owner, but we are clearly not yet at the HA code owner stage.

@lextm lextm deleted the better-sensor branch March 17, 2024 03:49
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNMP sensor and OPAQUE data type
4 participants