Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch API errors in cast media_player service handlers #113839

Merged
merged 3 commits into from Mar 20, 2024

Conversation

emontnemery
Copy link
Contributor

Proposed change

Catch API errors in cast media_player service handlers and reraise as HomeAssistantError

This is needed because pychromecast 14.0.0 raises errors on timeout etc.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a test failure.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft March 20, 2024 00:21
@emontnemery emontnemery marked this pull request as ready for review March 20, 2024 07:13
@MartinHjelmare MartinHjelmare marked this pull request as draft March 20, 2024 11:00
@emontnemery emontnemery marked this pull request as ready for review March 20, 2024 12:10
@emontnemery emontnemery merged commit afa9517 into dev Mar 20, 2024
20 of 21 checks passed
@emontnemery emontnemery deleted the cast_catch_exceptions branch March 20, 2024 12:10
@emontnemery
Copy link
Contributor Author

I'll improve test coverage in a follow-up

@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

media_stop service throws an UNKNOWN_ERROR when targeting a chromecast device
3 participants