Deprecate speed limit lock in Tessie #113848

Bre77 · 2024-03-19T22:45:21Z

Proposed change

Disables speed limit lock by default and adds a warning message that it will be removed in 2024.11.0
As requested by @frenck

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

joostlek

We have some methods that also check if an entity is used in an automation. I think we use it in lutron light platform and harmony switch platform

home-assistant · 2024-03-27T09:27:20Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

gjohansson-ST · 2024-03-27T09:30:34Z

It would be better to check this when setting up the entity.

If already in entity reg, make issue and set it up
If not in entity reg, don't make issue and don't create entity (so new setups don't get this entity at all)

Bre77 · 2024-03-27T09:59:06Z

It would be better to check this when setting up the entity.

If already in entity reg, make issue and set it up

If not in entity reg, don't make issue and don't create entity (so new setups don't get this entity at all)

Thats going to cause an issue to be created for every integration user even if they have never touched the entity. I assume the repair action would be to disable it? Is there an example of where this has been done before because it seems a fair bit more complex to implement.

Bre77 · 2024-03-27T10:22:07Z

Ok ive seen the way lutron does it and that seems reasonable. Hopefully it doesnt kill test coverage.

Bre77 · 2024-03-27T21:35:35Z

lutron broke coverage in a way I have no idea how to fix, so doing the harmony way instead.

homeassistant/components/tessie/lock.py

homeassistant/components/tessie/strings.json

homeassistant/components/tessie/lock.py

tests/components/tessie/test_lock.py

homeassistant/components/tessie/lock.py

Co-authored-by: G Johansson <goran.johansson@shiftit.se>

gjohansson-ST · 2024-04-02T17:15:16Z

tests/components/tessie/test_lock.py

@@ -72,18 +83,39 @@ async def test_locks(
        assert hass.states.get(entity_id).state == STATE_UNLOCKED
        mock_run.assert_called_once()

+
+async def test_speed_limit_lock(


Could we just add to test that the issues are created correctly?

Done. Sorry for the delay.

homeassistant/components/tessie/strings.json

Co-authored-by: G Johansson <goran.johansson@shiftit.se>

Bre77 · 2024-04-24T07:43:29Z

@gjohansson-ST I think this needs to make it into 2024.5, so can you please review the final changes you requested?

homeassistant/components/tessie/strings.json

stale

gjohansson-ST

Approved once CI passes. I hope I did it correctly with the translations links.
Thanks @Bre77 👍

Bre77 added 2 commits March 19, 2024 22:43

Deprecate speed limit lock

c93879f

Change to 2024.6

9dbffa4

home-assistant bot added cla-signed deprecation Indicates a breaking change to happen in the future has-tests integration: tessie small-pr PRs with less than 30 lines. by-code-owner Quality Scale: No score labels Mar 19, 2024

Use issue registry instead

0619b1f

joostlek previously requested changes Mar 27, 2024

View reviewed changes

home-assistant bot marked this pull request as draft March 27, 2024 09:27

Bre77 added 2 commits March 27, 2024 10:32

Rework issue

045d12d

fix unique id

fbe4758

Bre77 added 2 commits March 28, 2024 00:17

Rework issue

32aee9f

Address lock coverage

6961709

Bre77 marked this pull request as ready for review March 28, 2024 04:48

home-assistant bot requested a review from joostlek March 28, 2024 04:48

gjohansson-ST requested changes Mar 28, 2024

View reviewed changes

homeassistant/components/tessie/lock.py Show resolved Hide resolved

homeassistant/components/tessie/lock.py Show resolved Hide resolved

homeassistant/components/tessie/lock.py Outdated Show resolved Hide resolved

homeassistant/components/tessie/strings.json Outdated Show resolved Hide resolved

home-assistant bot marked this pull request as draft March 28, 2024 09:06

Remove restart line and set fixable=False

733b626

Bre77 marked this pull request as ready for review March 28, 2024 09:14

home-assistant bot requested a review from gjohansson-ST March 28, 2024 09:14

gjohansson-ST requested changes Mar 30, 2024

View reviewed changes

homeassistant/components/tessie/lock.py Outdated Show resolved Hide resolved

home-assistant bot marked this pull request as draft March 30, 2024 14:15

gjohansson-ST requested changes Mar 30, 2024

View reviewed changes

homeassistant/components/tessie/lock.py Outdated Show resolved Hide resolved

Fix flow maybe?

9e86d19

Bre77 marked this pull request as ready for review March 31, 2024 02:08

home-assistant bot requested a review from gjohansson-ST March 31, 2024 02:08

Close but sitll not working

ba0c9d1

gjohansson-ST requested changes Apr 1, 2024

View reviewed changes

tests/components/tessie/test_lock.py Outdated Show resolved Hide resolved

tests/components/tessie/test_lock.py Show resolved Hide resolved

homeassistant/components/tessie/lock.py Outdated Show resolved Hide resolved

homeassistant/components/tessie/lock.py Outdated Show resolved Hide resolved

home-assistant bot marked this pull request as draft April 1, 2024 15:53

Bre77 and others added 4 commits April 2, 2024 07:44

Update tests/components/tessie/test_lock.py

e885d25

Co-authored-by: G Johansson <goran.johansson@shiftit.se>

Update homeassistant/components/tessie/lock.py

0186038

Co-authored-by: G Johansson <goran.johansson@shiftit.se>

Fix battery heaterUpdates

67ae8ad

2024.11

80aee29

Bre77 marked this pull request as ready for review April 1, 2024 21:54

home-assistant bot requested a review from gjohansson-ST April 1, 2024 21:54

Fix coverage

f6f3c8e

gjohansson-ST requested changes Apr 2, 2024

View reviewed changes

home-assistant bot marked this pull request as draft April 2, 2024 17:17

Bre77 and others added 2 commits April 7, 2024 09:55

Apply suggestions from code review

d5fa01b

Co-authored-by: G Johansson <goran.johansson@shiftit.se>

Test for issues

852592c

Bre77 marked this pull request as ready for review April 15, 2024 01:42

home-assistant bot requested a review from gjohansson-ST April 15, 2024 01:42

gjohansson-ST reviewed Apr 24, 2024

View reviewed changes

Apply suggestions from code review

4057dbd

gjohansson-ST approved these changes Apr 24, 2024

View reviewed changes

gjohansson-ST merged commit 0e0b543 into home-assistant:dev Apr 24, 2024
24 checks passed

Bre77 deleted the tessie-removelock branch April 24, 2024 11:39

github-actions bot locked and limited conversation to collaborators Apr 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate speed limit lock in Tessie #113848

Deprecate speed limit lock in Tessie #113848

Bre77 commented Mar 19, 2024 •

edited by gjohansson-ST

joostlek left a comment

home-assistant bot commented Mar 27, 2024

gjohansson-ST commented Mar 27, 2024

Bre77 commented Mar 27, 2024

Bre77 commented Mar 27, 2024

Bre77 commented Mar 27, 2024

gjohansson-ST Apr 2, 2024

Bre77 Apr 15, 2024

Bre77 commented Apr 24, 2024

gjohansson-ST left a comment

Deprecate speed limit lock in Tessie #113848

Deprecate speed limit lock in Tessie #113848

Conversation

Bre77 commented Mar 19, 2024 • edited by gjohansson-ST

Proposed change

Type of change

Additional information

Checklist

joostlek left a comment

Choose a reason for hiding this comment

home-assistant bot commented Mar 27, 2024

gjohansson-ST commented Mar 27, 2024

Bre77 commented Mar 27, 2024

Bre77 commented Mar 27, 2024

Bre77 commented Mar 27, 2024

gjohansson-ST Apr 2, 2024

Choose a reason for hiding this comment

Bre77 Apr 15, 2024

Choose a reason for hiding this comment

Bre77 commented Apr 24, 2024

gjohansson-ST left a comment

Choose a reason for hiding this comment

Bre77 commented Mar 19, 2024 •

edited by gjohansson-ST