Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define PARALLEL_UPDATES for APCUPSD #114134

Conversation

yuxincs
Copy link
Contributor

@yuxincs yuxincs commented Mar 24, 2024

Proposed change

This PR sets the appropriate PARALLEL_UPDATES values for APCUPSD integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was some kind of guideline that if the integration uses a coordinator, parallel updates doesnt have to be set iirc. @MartinHjelmare

@yuxincs
Copy link
Contributor Author

yuxincs commented Mar 24, 2024

Feel free to close this PR if it is actually not needed. I was mostly following https://developers.home-assistant.io/docs/integration_quality_scale_index/#platinum- which states that an appropriate values should be set 😃

@MartinHjelmare
Copy link
Member

MartinHjelmare commented Mar 25, 2024

Besides updates the parallel updates constant is also used for entity service calls that target more than one entity. It could still be useful in the service call case even if it's not useful for entity state updates, when using a coordinator.

@MartinHjelmare
Copy link
Member

In this case though it's probably not useful since binary sensors and sensors are unlikely to be targets in service calls.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve. It's likely not needed but also doesn't hurt and will help if there would be an entity service for these platforms even though it's unlikely.

@MartinHjelmare MartinHjelmare merged commit 071c3ab into home-assistant:dev Mar 28, 2024
21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
@yuxincs yuxincs deleted the yuxincs/apcupsd-implement-parallel-updates branch May 13, 2024 00:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants