-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace partial annotations #114177
Replace partial annotations #114177
Conversation
Hey there @emontnemery, @jbouwh, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
utcnow: partial[dt.datetime] = partial(dt.datetime.now, UTC) | ||
utcnow = partial(dt.datetime.now, UTC) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The partial[dt.datetime]
annotations is unnecessary. That's what's inferred implicitly already.
class RecordCallsPartial(partial[Any]): | ||
"""Wrapper class for partial.""" | ||
|
||
__name__ = "RecordCallPartialTest" | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to be used anywhere.
Hmm, was for another case. |
a4b6166
to
9f535e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Thnx @cdce8p 👍
Proposed change
Replace
partial
annotations. Support for it, aside the implicit case withpartial(some_function, val)
, isn't great. It's much better to useCallable
or even callback protocols.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: