Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ambient Weather to include Lightning Strike Time and Distance #114255

Merged
merged 13 commits into from
Apr 6, 2024

Conversation

strawgate
Copy link
Contributor

@strawgate strawgate commented Mar 26, 2024

Proposed change

Update Ambient Weather to include Lightning Strike Distance. It currently supports strikes per day and strikes per hour.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@strawgate strawgate requested a review from bachya as a code owner March 26, 2024 16:50
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @strawgate

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

Hey there @bachya, mind taking a look at this pull request as it has been labeled with an integration (ambient_station) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ambient_station can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ambient_station Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@bachya bachya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👏🏻

@bachya bachya marked this pull request as ready for review March 26, 2024 18:42
@strawgate
Copy link
Contributor Author

It looks like you made some commits here -- is there anything else i should plan on doing to get this merged?

@home-assistant home-assistant bot marked this pull request as draft March 31, 2024 22:53
@strawgate
Copy link
Contributor Author

CI Failure seems unrelated to my PR, so I've incorporated PR feedback and synced with dev.

Error: venv/lib/python3.12/site-packages/slixmpp/xmlstream/resolver.py:47: error: Skipping analyzing "aiodns": module is installed, but missing library stubs or py.typed marker  [import-untyped]
Error: venv/lib/python3.12/site-packages/aiohttp/resolver.py:11: error: Skipping analyzing "aiodns": module is installed, but missing library stubs or py.typed marker  [import-untyped]
venv/lib/python3.12/site-packages/aiohttp/resolver.py:11: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 2 errors in 2 files (checked 7 source files)
Error: Process completed with exit code 1.

@strawgate strawgate marked this pull request as ready for review April 6, 2024 13:26
strawgate

This comment was marked as duplicate.

@strawgate strawgate changed the title Update Ambient Weather to include Lightning Strike Distance Update Ambient Weather to include Lightning Strike Time Distance Apr 6, 2024
@strawgate strawgate changed the title Update Ambient Weather to include Lightning Strike Time Distance Update Ambient Weather to include Lightning Strike Time and Distance Apr 6, 2024
@strawgate
Copy link
Contributor Author

I also noticed the component is not syncing the last lightning strike time either so I've gone ahead and added that as well so this PR now includes last lightning strike time and last lightning strike distance

Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @strawgate 👍

@gjohansson-ST gjohansson-ST merged commit ed451ca into home-assistant:dev Apr 6, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ambient Weather missing Lightning Strike Distance
4 participants