Use setup_test_component_platform helper for switch entity component tests instead of hass.components
#114305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t tests instead of `hass.components`
home-assistant
bot
added
cla-signed
code-quality
core
has-tests
integration: generic_thermostat
integration: generic_hygrostat
integration: switch
small-pr
|
Hey there @Shulyaka, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
MartinHjelmare
requested changes
Mar 27, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
MartinHjelmare
requested changes
Mar 27, 2024
MartinHjelmare
approved these changes
Mar 28, 2024
| @@ -42,8 +42,8 @@ async def async_turn_off(hass, entity_id=ENTITY_MATCH_ALL): | |||
| await hass.services.async_call(DOMAIN, SERVICE_TURN_OFF, data, blocking=True) | |||
|
|
|||
|
|
|||
| def get_mock_switch_entities() -> list[MockToggleEntity]: | |||
| """Return a list of mock switch entities.""" | |||
| def get_mock_toggle_entities() -> list[MockToggleEntity]: | |||
There was a problem hiding this comment.
In the future we should change this to use actual SwitchEntity instead, since that's what the switch platform uses.
There was a problem hiding this comment.
Yes, definitely, I'll have a look when I've finished removing hass.components.
jpbede
force-pushed
the
switch-entity-tests-hass-components
branch
from
0a15df9
to
aa67231
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Make use of the
setup_test_component_platformhelperswitchentity component tests,generic_thermostatandgerneric_hygrostattests instead of a custom component intesting_config. Main reason for this is to get rid of the deprecatedhass.componentsuse.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: