Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid changing local time on Nobø Ecohub #114332

Merged
merged 1 commit into from Mar 28, 2024

Conversation

oyvindwe
Copy link
Contributor

@oyvindwe oyvindwe commented Mar 27, 2024

Proposed change

Fixes an issue where the time of the Nobø Ecohub is set wrong during the handshake in the case where localtime uses a different time zone than the hub is configured with (when using the mobile app).

For detail, see echoromeo/pynobo#35

The fix required a change in the upstream library: pynobo 1.8.0
Note that this PR also includes changes in 1.6.1 and 1.7.0

Full library diff: echoromeo/pynobo@v1.6.0...v1.8.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @echoromeo, mind taking a look at this pull request as it has been labeled with an integration (nobo_hub) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of nobo_hub can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign nobo_hub Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MartinHjelmare MartinHjelmare changed the title nobo_hub: Avoid changing local time on Nobø Ecohub Avoid changing local time on Nobø Ecohub Mar 27, 2024
@TheJulianJES TheJulianJES added this to the 2024.4.0 milestone Mar 28, 2024
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oyvindwe 👍

@gjohansson-ST gjohansson-ST merged commit 596436d into home-assistant:dev Mar 28, 2024
35 checks passed
@oyvindwe oyvindwe deleted the nobo_hub-fix-timezone branch March 28, 2024 12:58
frenck pushed a commit that referenced this pull request Mar 28, 2024
nobo_hub: Pass timezone to avoid changing local time on Nobø Ecohub in handshake
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants