Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyunifiprotect to 5.1.2 #114348

Merged
merged 1 commit into from Mar 28, 2024
Merged

Conversation

AngellusMortis
Copy link
Contributor

@AngellusMortis AngellusMortis commented Mar 28, 2024

Proposed change

Changelog: AngellusMortis/pyunifiprotect@v5.0.2...v5.1.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (unifiprotect) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of unifiprotect can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign unifiprotect Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@AngellusMortis AngellusMortis marked this pull request as draft March 28, 2024 02:14
@AngellusMortis
Copy link
Contributor Author

Loading sessions from disk does not work if an aiohttp session is passed in. Need to handle that.

@AngellusMortis AngellusMortis force-pushed the bump-ufp branch 2 times, most recently from 47096a1 to 31ddb5e Compare March 28, 2024 13:12
@AngellusMortis AngellusMortis marked this pull request as ready for review March 28, 2024 13:12
@AngellusMortis AngellusMortis changed the title Bump pyunifiprotect to 5.1.0 Bump pyunifiprotect to 5.1.1 Mar 28, 2024
@AngellusMortis AngellusMortis changed the title Bump pyunifiprotect to 5.1.1 Bump pyunifiprotect to 5.1.2 Mar 28, 2024
@bdraco
Copy link
Member

bdraco commented Mar 28, 2024

Tested on smaller production. All good

Testing on larger production now

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdraco
Copy link
Member

bdraco commented Mar 28, 2024

Testing looks good on the larger instance as well

Restarted a few times as well

@bdraco bdraco merged commit 435781b into home-assistant:dev Mar 28, 2024
35 checks passed
frenck pushed a commit that referenced this pull request Mar 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants