-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate hass.helpers
#114484
Merged
MartinHjelmare
merged 5 commits into
home-assistant:dev
from
jpbede:deprecate-hass-helpers
Mar 31, 2024
Merged
Deprecate hass.helpers
#114484
MartinHjelmare
merged 5 commits into
home-assistant:dev
from
jpbede:deprecate-hass-helpers
Mar 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
core
deprecation
Indicates a breaking change to happen in the future
labels
Mar 30, 2024
5 tasks
Looks like we are using it in recent code |
Yes, but should be just tests only. I removed the use in the category registry already. |
bdraco
approved these changes
Mar 31, 2024
MartinHjelmare
approved these changes
Mar 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
When we deprecated
hass.components
and@bind_hass
, we completely forgot to deprecatehass.helpers
, which is also relayed on@bind_hass
. So we have to deprecate this too. Idk if we should add this to the 2024.04 release.Dev blog: home-assistant/developers.home-assistant#2130
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: