Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This fixes an issue where the ZHA websocket test did not compare the websocket API configuration to the expected configuration, but instead always to itself, as the initial config was always overwritten.
This issue was noticed by @autinerd here: https://github.com/home-assistant/core/pull/114470/files/821eec8e2ce01bbda204c095f16dc5154bc4ab20#r1545303606
Background on the change:
As we do not use
device_ias_ace
fixture in this test (thus "no alarm device in the network"), ZHA does not add alarm config options anymore, so they won't be in the final config that you get from the websocket API.As this test uses the initial config to compare to (just modifies the light transition part to update one config option), we now use the base config without alarm options instead of the one with alarm options.
An alternative solution would be to add the
device_ias_ace
fixture to the test and compare toCONFIG_WITH_ALARM_OPTIONS
, but the test above this one already tests that functionality, so I don't see much reason in duplicating that into this test too.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: