Add Deconz support for Zigbee green power devices like Hue Tap #11455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinloaf
reviewed
Jan 7, 2018
| @@ -26,13 +25,13 @@ def async_setup_platform(hass, config, async_add_devices, discovery_info=None): | |||
| if discovery_info is None: | |||
| return | |||
|
|
|||
| from pydeconz.sensor import DECONZ_SENSOR | |||
| from pydeconz.sensor import DECONZ_SENSOR, SWITCH | |||
There was a problem hiding this comment.
To avoid confusion, I would suggest changing this to …, SWITCH as DECONZ_SWITCH here, since the term switch in HA refers to actuators, not sensors.
MartinHjelmare
approved these changes
Jan 15, 2018
MartinHjelmare
changed the title
|
@MartinHjelmare it was just a hopeful wish |
Merged
ghost
removed
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add support for Zigbee green power devices such as the Hue Tap.
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.