Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Starlink integration startup issue #114615

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Fix Starlink integration startup issue #114615

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
091538e
Update coordinator.py
Fexiven Apr 2, 2024
1546708
Merge branch 'dev' into dev
Fexiven Apr 2, 2024
bd277a7
Merge branch 'dev' into dev
Fexiven Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions homeassistant/components/starlink/coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,14 @@ def __init__(self, hass: HomeAssistant, name: str, url: str) -> None:
async def _async_update_data(self) -> StarlinkData:
async with asyncio.timeout(4):
try:
status, location, sleep = await asyncio.gather(
self.hass.async_add_executor_job(status_data, self.channel_context),
self.hass.async_add_executor_job(
location_data, self.channel_context
),
self.hass.async_add_executor_job(
get_sleep_config, self.channel_context
),
status = await self.hass.async_add_executor_job(
status_data, self.channel_context
)
location = await self.hass.async_add_executor_job(
location_data, self.channel_context
)
sleep = await self.hass.async_add_executor_job(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of scheduling three executor jobs sequentially, we should rewrite this to just schedule one executor job and do all the sync work in a single function. Create a function that calls status_data, location_data and get_sleep_config and schedule the function once on the executor.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented this on the previous PR two weeks ago:
#103057 (comment)

get_sleep_config, self.channel_context
)
return StarlinkData(location, sleep, *status)
except GrpcError as exc:
Expand Down