-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra sensors to Swiss Public Transport #114636
Merged
joostlek
merged 5 commits into
home-assistant:dev
from
miaucl:spt_no_more_extra_state_attributes
Apr 2, 2024
Merged
Add extra sensors to Swiss Public Transport #114636
joostlek
merged 5 commits into
home-assistant:dev
from
miaucl:spt_no_more_extra_state_attributes
Apr 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
integration: swiss_public_transport
new-feature
labels
Apr 2, 2024
Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
joostlek
changed the title
Convert extra_state_attributes to sensors
Add extra sensors to Swiss Public Transport
Apr 2, 2024
joostlek
requested changes
Apr 2, 2024
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
joostlek
reviewed
Apr 2, 2024
joostlek
approved these changes
Apr 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
The information available prior in the extra state attributes of the sensors is being replaced by a handful of individual sensors. All information remains available in this new form. Please adapt your scripts and lambdas to this new implementation.
Proposed change
The remaining information still available in the state attributes are now transformed into individual sensors and a deprecation notice is raised.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: