Validate unique_id in entity registry #114648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecode
reviewed
Apr 2, 2024
thecode
approved these changes
Apr 2, 2024
thecode
approved these changes
Apr 2, 2024
Kane610
approved these changes
Apr 2, 2024
balloob
reviewed
Apr 2, 2024
| _validate_item( | ||
| self.hass, domain, entity["platform"], entity["unique_id"] | ||
| ) | ||
| except (TypeError, ValueError): |
There was a problem hiding this comment.
Could we add a test for this part?
balloob
approved these changes
Apr 2, 2024
Co-authored-by: Shay Levy <levyshay1@gmail.com>
emontnemery
force-pushed
the
entity_registry_validate_unique_id
branch
from
84e1c2b
to
72dba26
Compare
bdraco
reviewed
Apr 4, 2024
|
Testing this now on production |
bdraco
approved these changes
Apr 4, 2024
| ), | ||
| entity["entity_id"], | ||
| entity["platform"], | ||
| str(err), |
There was a problem hiding this comment.
Exceptions have a string magic method so we don't need to copy them to a string.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Validate
unique_idin entity registry to avoid crashing core if theunique_idis not hashableNote: This does not fix a new regression, but we keep getting reports about integrations breaking core startup because of invalid entity ids
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: