Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid useless done check in config entries async_create_task #114695

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 3, 2024

Proposed change

If the task is not started with eager_start it will never be done right away

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

If the task is not started with eager_start it will
never be done right away
@home-assistant home-assistant bot added cla-signed code-quality core small-pr PRs with less than 30 lines. labels Apr 3, 2024
@bdraco bdraco marked this pull request as ready for review April 3, 2024 01:49
@bdraco bdraco requested a review from a team as a code owner April 3, 2024 01:49
@MartinHjelmare MartinHjelmare merged commit 41a88c8 into dev Apr 3, 2024
35 checks passed
@MartinHjelmare MartinHjelmare deleted the config_entry_useless_done branch April 3, 2024 09:49
@bdraco
Copy link
Member Author

bdraco commented Apr 3, 2024

thanks

@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants