Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always run keyed event trackers immediately #114709

Merged
merged 10 commits into from
Apr 5, 2024
Merged

Always run keyed event trackers immediately #114709

merged 10 commits into from
Apr 5, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 3, 2024

Proposed change

All of the known races that required us to run these with a call_soon have been fixed. There are a few tests that need to be adjusted since they will see a state change one loop sooner (or were missing a async_block_till_done).

generic_thermostat has some questionable tests, but the code seems like it works fine in production.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

All of the races that required us to run these with a call_soon
should have been fixed.
@bdraco
Copy link
Member Author

bdraco commented Apr 3, 2024

The test failures for generic thermostat might be actual bugs

@bdraco
Copy link
Member Author

bdraco commented Apr 4, 2024

The generic thermostat tests only worked because they are missing async_block_till_done after _setup_sensor. As soon as I add it, it fails on dev as well

    _setup_sensor(hass, sensor_temperature)

@bdraco bdraco marked this pull request as ready for review April 5, 2024 01:29
@bdraco bdraco requested a review from a team as a code owner April 5, 2024 01:29
@bdraco bdraco merged commit d321906 into dev Apr 5, 2024
38 checks passed
@bdraco bdraco deleted the always_run_imm branch April 5, 2024 01:30
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants