Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index for area/config_entry/label to the device registry #114776

Merged
merged 6 commits into from
Apr 4, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 3, 2024

Proposed change

Add index for area/config_entry/label to the device registry to avoid linear search when calling async_entries_for_area, async_entries_for_label, or async_entries_for_config_entry

This will speed up search, async_extract_referenced_entity_ids, the template call

entries = device_registry.async_entries_for_label(dev_reg, _label_id)
and any integration that uses the other calls.

git grep dr.async_entries_for_config_entry homeassistant|wc
      47     225    5344

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco bdraco marked this pull request as ready for review April 3, 2024 21:02
@bdraco bdraco requested a review from a team as a code owner April 3, 2024 21:02
@balloob balloob merged commit 3f76d1f into dev Apr 4, 2024
38 checks passed
@balloob balloob deleted the device_registry_index branch April 4, 2024 02:52
@bdraco
Copy link
Member Author

bdraco commented Apr 4, 2024

Thanks

@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants