Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Axis reconfigure step not providing protocols as alternatives but as string #114889

Merged

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Apr 4, 2024

Breaking change

Proposed change

The change was to go from str to vol.In(PROTOCOL_CHOICES)

Screenshot 2024-04-04 at 21 15 04 Screenshot 2024-04-04 at 21 15 42

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@Kane610
Copy link
Member Author

Kane610 commented Apr 4, 2024

Pylint fail is unrelated

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Kane610 👍

../Frenck

@frenck frenck merged commit b67e9b2 into home-assistant:dev Apr 5, 2024
24 checks passed
@Kane610 Kane610 deleted the axis-fix_reconfigure_protocol_as_string branch April 5, 2024 07:52
@Kane610
Copy link
Member Author

Kane610 commented Apr 5, 2024

Awesome! Thank you @frenck 🎉

frenck pushed a commit that referenced this pull request Apr 5, 2024
@frenck frenck mentioned this pull request Apr 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Axis reconfigure and no video on dashboard
2 participants