-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenAI conversation entity #114942
Add OpenAI conversation entity #114942
Conversation
Hey there @home-assistant/core, @synesthesiam, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a hassfest error.
Add tests for the new APIs? Would be good to exercise the prompt override.
The new APIs are tested by changing the agent ID from using the config entry to the entity ID. |
I mean the new prompt field which I think doesn't exist in the old API. |
I didn't change the API, just move the code around. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, i misread the "raw_prompt" code and made some assumptions about how i wanted it to work.
Still hassfest error:
|
Yeah, I have some changes locally but need to figure out the migration first. I thought that I could avoid it, but I cannot. |
2e2ab41
to
7124dab
Compare
|
||
def __init__(self, hass: HomeAssistant, entry: ConfigEntry) -> None: | ||
"""Initialize the agent.""" | ||
self.hass = hass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't pass in hass.
Breaking change
Proposed change
Add a conversation entity to the OpenAI integration. This is backwards compatible as we still register the agent too, so no migration path has been included.
To do
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: