Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenAI conversation entity #114942

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Add OpenAI conversation entity #114942

merged 2 commits into from
Apr 9, 2024

Conversation

balloob
Copy link
Member

@balloob balloob commented Apr 5, 2024

Breaking change

Proposed change

Add a conversation entity to the OpenAI integration. This is backwards compatible as we still register the agent too, so no migration path has been included.

To do

  • migrate assist pipeline to use entity?
  • Unique Id to avoid changing entity id

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Apr 5, 2024

Hey there @home-assistant/core, @synesthesiam, mind taking a look at this pull request as it has been labeled with an integration (conversation) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of conversation can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign conversation Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a hassfest error.

Add tests for the new APIs? Would be good to exercise the prompt override.

@balloob
Copy link
Member Author

balloob commented Apr 5, 2024

The new APIs are tested by changing the agent ID from using the config entry to the entity ID.

@allenporter
Copy link
Contributor

The new APIs are tested by changing the agent ID from using the config entry to the entity ID.

I mean the new prompt field which I think doesn't exist in the old API.

@balloob
Copy link
Member Author

balloob commented Apr 6, 2024

I didn't change the API, just move the code around.

Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, i misread the "raw_prompt" code and made some assumptions about how i wanted it to work.

@allenporter
Copy link
Contributor

There is a hassfest error.

Still hassfest error:

Error: R] [MANIFEST] Domain should not have an IoT Class

@balloob
Copy link
Member Author

balloob commented Apr 7, 2024

Yeah, I have some changes locally but need to figure out the migration first. I thought that I could avoid it, but I cannot.

@balloob balloob force-pushed the openai-conversation-entity branch from 2e2ab41 to 7124dab Compare April 8, 2024 15:32
@balloob balloob merged commit 2df6f18 into dev Apr 9, 2024
19 of 20 checks passed
@balloob balloob deleted the openai-conversation-entity branch April 9, 2024 15:10
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024

def __init__(self, hass: HomeAssistant, entry: ConfigEntry) -> None:
"""Initialize the agent."""
self.hass = hass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't pass in hass.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants