Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typo in IMAP translation #115032

Merged
merged 1 commit into from
Apr 6, 2024
Merged

Correct typo in IMAP translation #115032

merged 1 commit into from
Apr 6, 2024

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Apr 6, 2024

Proposed change

correct typo in execption text

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@@ -43,7 +43,7 @@
"message": "Marking the the message for deletion failed with \"{error}\"."
},
"expunge_failed": {
"message": "Expungling the the message failed with \"{error}\"."
"message": "Expunging the the message failed with \"{error}\"."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is an expunge in the first place?

Copy link
Contributor

@autinerd autinerd Apr 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting an e-mail does not really delete the e-mail in the IMAP protocol, it is rather only marked for deletion. The IMAP EXPUNGE command is then used to really delete the e-mails on the server which are marked for deletion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A definite form of erasing. The IMAP command is called this way.

@jbouwh
Copy link
Contributor Author

jbouwh commented Apr 6, 2024

Thnx

@jbouwh jbouwh merged commit fa47e79 into dev Apr 6, 2024
24 checks passed
@jbouwh jbouwh deleted the imap-typo branch April 6, 2024 16:37
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants