Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __slots__ to NodeClass classes #115079

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Conversation

autinerd
Copy link
Contributor

@autinerd autinerd commented Apr 7, 2024

Proposed change

This adds the __slots__ attribute to NodeStrClass, NodeListClass and NodeDictClass and adds the __config_file__ and __line__ attributes fixed to these classes, so they do not need to be added dynamically.

Needed for #115043

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Copy link
Member

bdraco commented Apr 8, 2024

FAILED tests/components/todoist/test_calendar.py::test_update_entity_for_calendar_with_due_date_in_the_future[due0] - AssertionError: assert '2024-04-10 00:00:00' == '2024-04-11 00:00:00'

This test failure is unrelated. It seems to fail on day change over

@bdraco
Copy link
Member

bdraco commented Apr 8, 2024

I'll test this one locally before merging

@bdraco
Copy link
Member

bdraco commented Apr 8, 2024

We have a lot of RAM usage from these objects (enough that when we had the leak here it would very obvious) so its great to use more __slots__ here

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @autinerd

@bdraco bdraco merged commit 025c6f5 into home-assistant:dev Apr 8, 2024
33 of 34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2024
@autinerd autinerd deleted the nodeclass-slots branch April 12, 2024 14:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants