-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add binary sensor to Netatmo #115119
Add binary sensor to Netatmo #115119
Conversation
Hey there @cgtobi, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
await snapshot_platform_entities( | ||
hass, | ||
config_entry, | ||
Platform.BINARY_SENSOR, | ||
entity_registry, | ||
snapshot, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something we could make into a general helper function (not this PR)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point, i think we can make use of it
Co-authored-by: Jan-Philipp Benecke <github@bnck.me>
# Conflicts: # homeassistant/components/netatmo/sensor.py
Proposed change
Apparently there is a sensor with the state
True
,False
andNone
, so that sounds like a binary sensor instead of a normal sensor. So we deprecate the old one and use this.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: