Add number platform to Husqvarna Automower #115125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostlek
requested changes
Apr 7, 2024
8 tasks
joostlek
reviewed
Apr 23, 2024
Comment on lines
+68
to
+77
| entity_entries = er.async_entries_for_config_entry( | ||
| entity_registry, mock_config_entry.entry_id | ||
| ) | ||
|
|
||
| assert entity_entries | ||
| for entity_entry in entity_entries: | ||
| assert hass.states.get(entity_entry.entity_id) == snapshot( | ||
| name=f"{entity_entry.entity_id}-state" | ||
| ) | ||
| assert entity_entry == snapshot(name=f"{entity_entry.entity_id}-entry") |
There was a problem hiding this comment.
Suggested change
| entity_entries = er.async_entries_for_config_entry( | |
| entity_registry, mock_config_entry.entry_id | |
| ) | |
| assert entity_entries | |
| for entity_entry in entity_entries: | |
| assert hass.states.get(entity_entry.entity_id) == snapshot( | |
| name=f"{entity_entry.entity_id}-state" | |
| ) | |
| assert entity_entry == snapshot(name=f"{entity_entry.entity_id}-entry") | |
| await snapshot_platform(hass, entity_registry, snapshot, mock_config_entry.entry_id) |
New helper was added last weekend, if you could find the time to add this to the other paltforms as well, that'd be amazing :)
joostlek
added
the
smash
joostlek
approved these changes
Apr 23, 2024
tr4nt0r
pushed a commit
to tr4nt0r/ha-core
that referenced
this pull request
Apr 23, 2024
* Add number platform to Husqvarna Automower * use fixture to enable by default * replace state test with snapshot test * make property in entity description * send value as integer * give the exists functions something to do
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Adds the number platform to this integration, for changing the cutting height. This is a little bit tricky, because the API can't tell about the cutting height capabilities.
There are 4 different types of mowers, regarding the cutting height:
Type 1: Cutting height can only be changed manually and the mower reports no value for the cutting height: Fits perfect, won't be added
Type 2: Cutting height can only be changed manually and the mower reports
1for the cutting height: entity is disabled by default, and the user hopefully doesn't enable itType 3: Cutting height can only be changed manually and there is a sensor for the cutting hieght: entity is disabled by default, and the user can enable it and just use it as a sensor.
Type 4: Cutting height be changed by the API: entity is disabled by default, and the user can enable it, and use the full functionallity.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: