-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate calling async_listen and async_listen_once with run_immediately #115169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
commented
Apr 8, 2024
bdraco
commented
Apr 8, 2024
bdraco
requested review from
a team,
hunterjm,
uvjustin,
allenporter,
jjlawren,
balloob,
bieniu,
thecode,
chemelli74,
epenet,
Danielhiversen and
elupus
as code owners
April 8, 2024 19:29
bdraco
requested review from
Jc2k,
OttoWinter,
jesserockz,
synesthesiam,
ochlocracy and
jbouwh
as code owners
April 8, 2024 19:29
jbouwh
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Nice running immediately is now the default!
Thnx @bdraco 👍
CI Failure is not related |
thecode
approved these changes
Apr 8, 2024
thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla-signed
core
deprecation
Indicates a breaking change to happen in the future
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Calling
async_listen
orasync_listen_once
withrun_immediately
is deprecated, and the keyword argument will be removed in 2025.5. Since its unlikely anyone was callingrun_immediately
withFalse
as it was only ever in theevent
helper in core prior to the 2024.5 dev cycle, the default ofTrue
will always be used.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests:
needs
blog post -- probably not since its unlikely to be used outside of core and the solution is to remove the kwarg