Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Ruff PYI041 #115229

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Enable Ruff PYI041 #115229

merged 2 commits into from
Apr 8, 2024

Conversation

autinerd
Copy link
Contributor

@autinerd autinerd commented Apr 8, 2024

Proposed change

This enables the Ruff rule PYI041: Use float instead of int | float in argument annotations.

The Python typing spec contains that in argument type annotations, int is automatically included when using float, so int | float is redundant.
https://typing.readthedocs.io/en/latest/spec/special-types.html#special-cases-for-float-and-complex

I don't have a problem either if we would say to ignore this rule because it may be more confusing.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco bdraco added the second-opinion-wanted Add this label when a reviewer needs a second opinion from another member. label Apr 8, 2024
@bdraco
Copy link
Member

bdraco commented Apr 8, 2024

This makes sense to me, but I'd like a second opinion before merging as someone may feel otherwise about removing int

Copy link
Member

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@bdraco bdraco removed the second-opinion-wanted Add this label when a reviewer needs a second opinion from another member. label Apr 8, 2024
@bdraco
Copy link
Member

bdraco commented Apr 8, 2024

The Codecov failure is unrelated to this PR

@bdraco bdraco merged commit 9cbed10 into home-assistant:dev Apr 8, 2024
33 of 34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2024
@autinerd autinerd deleted the ruff-pyi041 branch April 12, 2024 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants