Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ring_doorbell library to 0.8.11 #115263

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

sdb9696
Copy link
Contributor

@sdb9696 sdb9696 commented Apr 9, 2024

Proposed change

Bump ring_doorbell dependency to 0.8.11. Minor bugfix in library for future use by HA.

https://github.com/tchellomello/python-ring-doorbell/releases/tag/0.8.11

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sdb9696
Does this need to be tagged for a patch release?

@sdb9696
Copy link
Contributor Author

sdb9696 commented Apr 9, 2024

Thanks @sdb9696 Does this need to be tagged for a patch release?

No, this does not impact anything current at the moment.

@bdraco
Copy link
Member

bdraco commented Apr 9, 2024

code cov failure is unrelated

@bdraco bdraco merged commit 0a57641 into home-assistant:dev Apr 9, 2024
33 of 34 checks passed
@sdb9696 sdb9696 deleted the bump_ring_doorbell branch April 9, 2024 10:19
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants