Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pymodbus v3.6.7 #115279

Merged
merged 1 commit into from Apr 9, 2024
Merged

Bump pymodbus v3.6.7 #115279

merged 1 commit into from Apr 9, 2024

Conversation

janiversen
Copy link
Member

@janiversen janiversen commented Apr 9, 2024

Breaking change

Proposed change

Update pymodbus to solve (hopefully) the problem introduced in 2024.4.0.

release log: https://github.com/pymodbus-dev/pymodbus/releases/tag/v3.6.7

change log: https://github.com/pymodbus-dev/pymodbus/blob/master/CHANGELOG.rst

Please be aware that there are no guarantees, that all problems are gone. If you experience problems, then
please open an issue, but please remember the following:

  • include a copy of the modbus configuration (preferable reduced to make it easier to analyze)
  • include a debug log as pr modbus integration documentation

If you have multiple modbus devices configured, then please try to run with one device at a time, and only report the failing device (a log with multiple devices are very complicated to analyze).

If you use custom_components, then please disable those before logging ! if you use a custom_component that internally use modbus, then please report any issues to the custom_component developers.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@janiversen
Copy link
Member Author

The failing test is in zwave_js and have nothing to do with this library bump.

@janiversen janiversen merged commit 51d5d51 into home-assistant:dev Apr 9, 2024
33 of 34 checks passed
@janiversen janiversen deleted the bump branch April 9, 2024 15:10
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modbus 2024.4.x problem tracker.
3 participants