Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Balboa spa temperature range state control (high/low) #115285

Merged
merged 11 commits into from
Apr 13, 2024

Conversation

kotope
Copy link
Contributor

@kotope kotope commented Apr 9, 2024

Proposed change

Adds temperature range switch support (high/low) to Balboa spa integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kotope

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Apr 9, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft April 9, 2024 14:49
@home-assistant
Copy link

home-assistant bot commented Apr 9, 2024

Hey there @garbled1, @natekspencer, mind taking a look at this pull request as it has been labeled with an integration (balboa) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of balboa can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign balboa Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@kotope
Copy link
Contributor Author

kotope commented Apr 9, 2024

Updated documentation PR: home-assistant/home-assistant.io#32236

@kotope kotope marked this pull request as ready for review April 9, 2024 14:56
@TheJulianJES TheJulianJES changed the title Add temperature range switch (high/low) to Balboa spa integration. Add Balboa spa temperature range switch (high/low) Apr 9, 2024
Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do find a switch entity somewhat confusing for this use case. I think a select entity would would make more sense here.

@home-assistant home-assistant bot marked this pull request as draft April 9, 2024 16:20
@kotope
Copy link
Contributor Author

kotope commented Apr 10, 2024

I do find a switch entity somewhat confusing for this use case. I think a select entity would would make more sense here.

Thanks for pointing out this @jpbede

I will do the change from switch to select soon and push a new commit :-)

@kotope kotope marked this pull request as ready for review April 10, 2024 13:20
@home-assistant home-assistant bot requested a review from jpbede April 10, 2024 13:20
@kotope
Copy link
Contributor Author

kotope commented Apr 10, 2024

I do find a switch entity somewhat confusing for this use case. I think a select entity would would make more sense here.

Changed to select entity now.

@kotope kotope changed the title Add Balboa spa temperature range switch (high/low) Add Balboa spa temperature range state control (high/low) Apr 10, 2024
homeassistant/components/balboa/icons.json Outdated Show resolved Hide resolved
homeassistant/components/balboa/select.py Outdated Show resolved Hide resolved
tests/components/balboa/test_select.py Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft April 12, 2024 19:03
@kotope
Copy link
Contributor Author

kotope commented Apr 13, 2024

Thanks for reviewing @jpbede!

Issues you mentioned should be resolved now.
Takes a while to get into HA + python. Hopefully my future tasks will go more smooth :-)

@kotope kotope marked this pull request as ready for review April 13, 2024 06:17
@home-assistant home-assistant bot requested a review from jpbede April 13, 2024 06:17
Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, worries we all started somewhen 🙂
This looks good now, thanks 👍

@jpbede jpbede merged commit 84a975b into home-assistant:dev Apr 13, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants