-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Balboa spa temperature range state control (high/low) #115285
Add Balboa spa temperature range state control (high/low) #115285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @garbled1, @natekspencer, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Updated documentation PR: home-assistant/home-assistant.io#32236 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do find a switch
entity somewhat confusing for this use case. I think a select
entity would would make more sense here.
Thanks for pointing out this @jpbede I will do the change from switch to select soon and push a new commit :-) |
….com/kotope/homeassistant_core into feature/balboa_spa_temperature_range
Changed to select entity now. |
…s attributes. Fix code comments.
Thanks for reviewing @jpbede! Issues you mentioned should be resolved now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, worries we all started somewhen 🙂
This looks good now, thanks 👍
Proposed change
Adds temperature range switch support (high/low) to Balboa spa integration.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: