Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting when an integration tries to create a task in a thread #115307

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 9, 2024

Proposed change

In 2024.4.x we saw a lot of reports of automations failing because integrations were trying to create asyncio tasks in another thread which is a non-thread-operation and was blocked because there is no running loop in the thread. Previously it didn't catch the bad operation because loop was being passed to the task creation. The error they would get is no running event loop which didn't provide much context. We now provide a full trace and show which integration has the problem.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @bdraco 👍

@bdraco
Copy link
Member Author

bdraco commented Apr 9, 2024

I'd mark this for backport, but it won't backport cleanly so I left off the milestone. Looks like users need to wait until 2024.5 to get a better trace

@bdraco
Copy link
Member Author

bdraco commented Apr 9, 2024

thanks

@bdraco bdraco merged commit f527fd0 into dev Apr 9, 2024
33 of 34 checks passed
@bdraco bdraco deleted the improve_error_reporting branch April 9, 2024 21:11
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants