-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add valve entity support for ESPHome #115341
Conversation
Hey there @OttoWinter, @jesserockz, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Awaiting esphome/aioesphomeapi#852 |
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: J. Nick Koston <nick@koston.org>
Looks like there are a few lines missing coverage homeassistant/components/esphome/valve.py 55 4 93% 65, 84, 90, 95 |
homeassistant/components/esphome/valve.py 53 0 100% 👍 |
Thanks @kbx81 |
Thank you, too, @bdraco! 🍻 |
Shoutout to @jesserockz, too, for help understanding the tests! 😅 |
Proposed change
Implements
valve
entity support for ESPHome.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: