Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add valve entity support for ESPHome #115341

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

kbx81
Copy link
Contributor

@kbx81 kbx81 commented Apr 10, 2024

Proposed change

Implements valve entity support for ESPHome.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @OttoWinter, @jesserockz, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign esphome Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@kbx81 kbx81 mentioned this pull request Apr 10, 2024
13 tasks
@kbx81
Copy link
Contributor Author

kbx81 commented Apr 10, 2024

Awaiting esphome/aioesphomeapi#852

@jesserockz jesserockz mentioned this pull request Apr 17, 2024
20 tasks
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: J. Nick Koston <nick@koston.org>
@bdraco
Copy link
Member

bdraco commented Apr 17, 2024

pytest --cov=homeassistant/components/esphome/ --cov-report term-missing -- tests/components/esphome

Looks like there are a few lines missing coverage

homeassistant/components/esphome/valve.py 55 4 93% 65, 84, 90, 95

@bdraco
Copy link
Member

bdraco commented Apr 18, 2024

homeassistant/components/esphome/valve.py 53 0 100%

👍

@bdraco
Copy link
Member

bdraco commented Apr 18, 2024

Thanks @kbx81

@kbx81
Copy link
Contributor Author

kbx81 commented Apr 18, 2024

Thank you, too, @bdraco! 🍻

@kbx81
Copy link
Contributor Author

kbx81 commented Apr 18, 2024

Shoutout to @jesserockz, too, for help understanding the tests! 😅

@bdraco bdraco merged commit 14515b7 into home-assistant:dev Apr 18, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants