Add bandwidth sensor for unifi device ports

[kimdv]

Proposed change

This PR aims to add bandwidth sensors for unify device ports.
It makes it possible to for users to track bandwidth usage on each port, so they can make nice dashboards.

I was considering to add only for WAN ports, but then I tought it might just be easier to add for all ports, and then let the users enable the ones they want to use.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @Kane610, mind taking a look at this pull request as it has been labeled with an integration (unifi) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of unifi can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign unifi Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[Kane610]

Thanks! Make these sensors disabled by default, I think these are just too many to populate all at once with the setting. I think over time that config will be removed and just have them disabled by default.

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[kimdv]

@Kane610 disabled by default now.
I also added more scenarios to the test case.

[wittypluck]

Hello,
this feature looks interesting !
Question/suggestion: why not leave the data in the native unit (bytes/seconds it seems), add a suggested unit, and let HA do the conversions ?
Something like :

        native_unit_of_measurement=UnitOfDataRate.BYTES_PER_SECOND,
        suggested_unit_of_measurement=UnitOfDataRate.MEGABITS_PER_SECOND,
..
        value_fn=lambda hub, port: port.raw.get("rx_bytes-r", 0),

[Kane610]

Hello, this feature looks interesting ! Question/suggestion: why not leave the data in the native unit (bytes/seconds it seems), add a suggested unit, and let HA do the conversions ? Something like :

        native_unit_of_measurement=UnitOfDataRate.BYTES_PER_SECOND,
        suggested_unit_of_measurement=UnitOfDataRate.MEGABITS_PER_SECOND,
..
        value_fn=lambda hub, port: port.raw.get("rx_bytes-r", 0),

Yes let's do this.

[kimdv]

@Kane610 @wittypluck I change to what is was suggested.

I also removed the supported_fn.

[Kane610]

Looks ok, will review tonight

[Kane610]

Final thing, it's good to keep unique ids unique per source as well. Just in case some migration is needed down the line

[Kane610]

Thanks! Next time try to avoid doing a rebase after fixing a comment, takes longer to look through.

[Kane610]

Maybe you could add a small note to the integration documentation about it as well?

[kimdv]

Thanks! Next time try to avoid doing a rebase after fixing a comment, takes longer to look through.

Should i just add commits with fixes and you will squash them?

And then rebase before merge ?

[Kane610]

Thanks! Next time try to avoid doing a rebase after fixing a comment, takes longer to look through.

Should i just add commits with fixes and you will squash them?

And then rebase before merge ?

Squash and merge is the common approach on this github repo so just bring on the commits ;)

I'm not saying you can't rebase everything into one commit but then I can't see the incremental changes

Rebase at the end is only needed if there is a merge conflict with dev