-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix zha test by tweaking the log level #115368
Conversation
Hey there @dmulcahey, @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fundamentally changes what the test is testing, however, no? Could the Home Assistant log handling be in a separate thread and thus caplog.text
may take an event loop step (or two) to populate?
For now it is just a test to see if the CI passes. If debug logging is filtered out some how, this could be the cause the logging it self fails. |
@puddly May be you can have a look at the linked failed CI test. As all is mocked out I cannot find a reason how this test could fail (I mean the original one), but somehow it does. |
Previous test passed. |
Well, the test with the log assertion also passes. No Idea what the root cause is of the CI failure linked in the PR description. |
@puddly may be the log processing is not finished yet, so an extra |
That was my original thought as well. Looks like the tests pass this run. |
Thnx! |
It would be nice if we can find the source of the not so isolated logger level change is happening, but this is fine for now as that may take a long time to uncover |
Proposed change
test_probe_failure_exception_handling
failed multiple times:https://github.com/home-assistant/core/actions/runs/8633392085/job/23671932070?pr=110950
Possible the asserting on debug log is an issue because the test used to lean on the debug level being set to DEBUG by another test. This PR set the log level to debug temporary to ensure the test passes.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: