Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cod.m Zigbee Coordinator for ZHA #115471

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

tsmt09
Copy link

@tsmt09 tsmt09 commented Apr 12, 2024

Breaking change

No breaking change

Proposed change

Adds cod.m Zigbee Coordinator integration for ZHA

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • (not applicable) Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

home-assistant[bot]

This comment was marked as resolved.

@home-assistant home-assistant bot marked this pull request as draft April 12, 2024 13:11
@home-assistant

This comment was marked as resolved.

@home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zha Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@tsmt09 tsmt09 marked this pull request as ready for review April 12, 2024 13:23
@MartinHjelmare MartinHjelmare changed the title Adds cod.m Zigbee Coordinator integration for ZHA Add cod.m Zigbee Coordinator integration for ZHA Apr 13, 2024
@MartinHjelmare MartinHjelmare changed the title Add cod.m Zigbee Coordinator integration for ZHA Add cod.m Zigbee Coordinator for ZHA Apr 13, 2024
@tsmt09
Copy link
Author

tsmt09 commented Apr 23, 2024

Hey, gently asking: the PR is currently stuck in "Collect information & changes data Expected — Waiting for status to be reported". Is there anything I can do to speed up the process?

@tsmt09
Copy link
Author

tsmt09 commented Apr 30, 2024

Rebased to dev instead of doing merges

@tsmt09
Copy link
Author

tsmt09 commented May 10, 2024

rebased to dev

@tsmt09
Copy link
Author

tsmt09 commented May 16, 2024

rebased to dev

@tsmt09
Copy link
Author

tsmt09 commented May 29, 2024

hey, don't want to pressure but just wanted to check in if there's anything wrong with the pullrequest and if I need to do anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants