-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure test async_create_task eager start behavior matches production #115517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
bdraco
changed the title
Ensure test eager start behavior matches production
Ensure test async_create_task eager start behavior matches production
Apr 13, 2024
bdraco
commented
Apr 13, 2024
bdraco
commented
Apr 13, 2024
bdraco
commented
Apr 13, 2024
The mobile_app channel teardown code would pop the websocket subscripton instead of the letting the websocket close code handle removing it which could lead to dictionary changed size during iteration since it removed a listener out from under it https://github.com/home-assistant/core/blob/64a4d52b3cca5fe4eb2843f27066fb7cd795aee3/homeassistant/components/websocket_api/connection.py#L232
This reverts commit a27cd5b.
bdraco
commented
Apr 13, 2024
bdraco
requested review from
a team,
rytilahti,
starkillerOG,
jjlawren,
emontnemery,
jbouwh and
ludeeus
as code owners
April 13, 2024 20:08
jbouwh
approved these changes
Apr 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Thnx @bdraco 👍
thanks |
balloob
approved these changes
Apr 13, 2024
FAILED tests/components/modbus/test_light.py::test_light_service_turn[do_config0] - AssertionError: assert 'off' == 'unavailable' is a flakey test and unrelated to this PR I'm going to rerun it just to be 100% sure though |
passed on second run |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
async_create_task
defaults toTrue
in production, but there was one remaining place in the test helpers were it defaulted toFalse
For cases where it was a simple such as a patch being set too late, I fixed the tests.
For other cases where defaulting to
True
that caused the test to fail, I set it toFalse
in the production code so they can analyzed and fixed in future PRsType of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: