Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure test async_create_task eager start behavior matches production #115517

Merged
merged 41 commits into from
Apr 13, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 13, 2024

Proposed change

async_create_task defaults to True in production, but there was one remaining place in the test helpers were it defaulted to False

  • For cases where it was a simple such as a patch being set too late, I fixed the tests.

  • For other cases where defaulting to True that caused the test to fail, I set it to False in the production code so they can analyzed and fixed in future PRs

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed core small-pr PRs with less than 30 lines. labels Apr 13, 2024
@bdraco bdraco changed the title Ensure test eager start behavior matches production Ensure test async_create_task eager start behavior matches production Apr 13, 2024
tests/common.py Outdated Show resolved Hide resolved
tests/common.py Outdated Show resolved Hide resolved
tests/common.py Show resolved Hide resolved
@bdraco bdraco marked this pull request as ready for review April 13, 2024 20:08
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thnx @bdraco 👍

@bdraco
Copy link
Member Author

bdraco commented Apr 13, 2024

thanks

@bdraco
Copy link
Member Author

bdraco commented Apr 13, 2024

FAILED tests/components/modbus/test_light.py::test_light_service_turn[do_config0] - AssertionError: assert 'off' == 'unavailable' is a flakey test and unrelated to this PR

I'm going to rerun it just to be 100% sure though

@bdraco
Copy link
Member Author

bdraco commented Apr 13, 2024

passed on second run

@bdraco bdraco merged commit ee535ee into dev Apr 13, 2024
34 checks passed
@bdraco bdraco deleted the eager_start_tests branch April 13, 2024 20:58
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants