Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Alexa entity id generation into abstract config class #115593

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

mback2k
Copy link
Contributor

@mback2k mback2k commented Apr 14, 2024

Proposed change

This makes it possible to change the ID schema in implementations.

I am currently working on an Alexa integration using the Alexa Voice Service (AVS) SDK which makes exposing Home Assistant to the internet and running a skill on AWS Lambda obsolete. Instead Home Assistant will directly connect to AVS servers and provide a backchannel for connected Smart Home endpoints. I already have a fully functioning prototype running locally, but need this change in core as a basis for the new integration based upon the AbstractConfig class.

Detail background for this change: AVS needs connected Smart Home endpoints (e.g. Home Assistant Devices/Entities) to follow a specific ID schema, like this: {client-id}::{product-id}::{device-serial-number}-{entity-id}.

This doesn't break existing behavior, code or integrations. It just makes it possible to overwrite this function. Therefore, I am looking forward to get this merged, thank you!

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • Preparation for New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

This makes it possible to change the id schema in implementations.
@home-assistant
Copy link

Hey there @home-assistant/cloud, @ochlocracy, @jbouwh, mind taking a look at this pull request as it has been labeled with an integration (alexa) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of alexa can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign alexa Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@mback2k mback2k marked this pull request as ready for review April 14, 2024 19:30
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thnx @mback2k 👍

@jbouwh jbouwh merged commit e08301f into home-assistant:dev Apr 14, 2024
38 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants