-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit of measurement for Comed Hourly Pricing #115594
base: dev
Are you sure you want to change the base?
Fix unit of measurement for Comed Hourly Pricing #115594
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @themaxgross
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
9fd870d
to
bb401c5
Compare
bb401c5
to
885c28c
Compare
@TheJulianJES forgive me for just tagging you like this, but not sure if I can clear any more blockers for this. From what I've seen, may need you or a similar codeowner to approve the GH Action to run the other checks. I've struggled to get this to build and test locally, hope that doesn't mean I can't contribute. Please let me know what else I can do for ya! |
Switches the native_unit_of_measurement for the ComEd Hourly Pricing to use more accurate units.
Builds upon #75083, which was closed without action. Includes suggested changes from that PR.
Breaking change
c
to¢/kWh
.Proposed change
Fixes #74831, previously proposed in #75083
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: