ipp: Make IPP protocol version configurable #115661
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @LorbusChris
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
home-assistant
bot
added
cla-needed
dependency
has-tests
integration: ipp
new-feature
small-pr
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @ctalkington, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
|
we could just pass version to most the calls, it'll merge over vs needing an option in pyipp |
|
We can't pass it to |
I think maybe allowing version to be optionally passed to |
LorbusChris
requested review from
a team,
dmulcahey,
Adminiuga,
puddly and
TheJulianJES
as code owners
frenck
removed request for
dmulcahey,
synesthesiam,
Adminiuga,
TheJulianJES,
joostlek,
jbouwh,
cgarwood,
teharris1,
farmio,
emontnemery,
starkillerOG,
Quentame,
Ernst79,
Kane610,
edenhaus,
puddly and
mib1185
frenck
added
smash
| @@ -215,6 +215,7 @@ def _show_setup_form(self, errors: dict | None = None) -> ConfigFlowResult: | |||
| vol.Required(CONF_BASE_PATH, default="/ipp/print"): str, | |||
| vol.Required(CONF_SSL, default=False): bool, | |||
| vol.Required(CONF_VERIFY_SSL, default=False): bool, | |||
| vol.Required(CONF_PROTO_VERSION, default=(2, 0)): tuple[int, int], | |||
There was a problem hiding this comment.
would need to see how config flow UI handles tuples, not sure ive ever tried
There was a problem hiding this comment.
indeed, could revert this back to bool (checkmark?) for the UI
There was a problem hiding this comment.
i think that is a sane option or maybe a dropdown backed by enum of the three common versions (1.1/2.0/2.1) but it would still involve some translations to tuple since itd need to be a string value if im not mistaken for UI purposes.
one of the specs regarding IPP Everywhere is that if you provide discovery info, you must support 2.0/2.1. we also dont use any features of 2.1 so 2.0 is what has been used since the start. so this option really only covers 1.1 from a HA manual standpoint.
There was a problem hiding this comment.
maybe just specify in the checkbox text that legacy is 1.1 or just "Use IPP v1.1 for compatibility with older printers" vs "legacy"
There was a problem hiding this comment.
Opting for the easy way with just a bool checkbox for now. String updated accordingly, please take another look :)
|
in the docs we may want to mention that older legacy printers are supported via manual config flow option but may lack certain sensors like ink levels. |
Proposed change
ipp: Make IPP protocol version configurable
Fixes: #93211
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: