Add support for Todoist sections #115671
Add support for Todoist sections #115671
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @cmbuckley
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @boralyl, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
cmbuckley
force-pushed
the
todoist-sections
branch
from
4d727c5
to
31b931c
Compare
frenck
added
the
smash
|
(Close + open to retrigger stuck CI) |
| # Optional section within project | ||
| section_id: str | None = None | ||
| if SECTION_NAME in call.data: | ||
| section_name = call.data[SECTION_NAME].lower() |
There was a problem hiding this comment.
Why do we call lower here, isn't lower case already guaranteed by the schema?
I think we should also, in a separate PR, remove the call to lower for the project name above.
| sections = await coordinator.async_get_sections(project_id) | ||
| for section in sections: | ||
| if section_name == section.name.lower(): | ||
| section_id = section.id |
There was a problem hiding this comment.
Also break out of the for loop when handling the project name above
| section_id = section.id | |
| section_id = section.id | |
| break |
| if section_name == section.name.lower(): | ||
| section_id = section.id | ||
| if section_id is None: | ||
| raise HomeAssistantError( |
There was a problem hiding this comment.
This should be a ServiceValidationError, with translation in strings.json. Same for the project name error.
frenck
removed
the
smash
Proposed change
Adds support for project sections in the Todoist integration, specifically the
todoist.new_taskservice.The section is optional. If it is not provided, the task will be added to the project as before. If the section is provided, it must be a name of an existing section within the given project. As with providing an incorrect project name, this will raise an error if the named section does not exist in the project.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: