-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate requirements per supported architecture #115708
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a merge conflict.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
emontnemery
commented
Apr 16, 2024
thecode
reviewed
Apr 16, 2024
emontnemery
force-pushed
the
per_arch_requirements
branch
from
April 16, 2024 15:50
05b3fe0
to
fde013a
Compare
20 tasks
emontnemery
commented
Apr 16, 2024
edenhaus
reviewed
Apr 17, 2024
emontnemery
force-pushed
the
per_arch_requirements
branch
from
April 17, 2024 12:07
0dbec28
to
69ad76a
Compare
edenhaus
reviewed
Apr 17, 2024
20 tasks
emontnemery
force-pushed
the
per_arch_requirements
branch
from
April 17, 2024 15:59
b1673e5
to
d2c65cf
Compare
edenhaus
reviewed
Apr 22, 2024
edenhaus
reviewed
Apr 22, 2024
edenhaus
approved these changes
Apr 22, 2024
tr4nt0r
pushed a commit
to tr4nt0r/ha-core
that referenced
this pull request
Apr 23, 2024
* Generate requirements per supported architecture * Don't store wheels requirements in the repo * Dry run * Set Python version * Install base packages * Fix * Fix * Fix * Fix typo Co-authored-by: Martin Hjelmare <marhje52@gmail.com> * Genarate requirements_all_pytest.txt * Fix hassfest * Reenable building wheels * Remove unneeded code * Address review comment * Fix lying comment * Add tests, address review comments * Deduplicate * Fix file name * Add comment --------- Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Generate requirements for pytest and for building wheels per supported architecture with
script/gen_requirements_all.py
instead of manipulating the requirement files with shell scripts in CI.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: