Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aiohttp-zlib-ng[isal] #115767

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Use aiohttp-zlib-ng[isal] #115767

merged 1 commit into from
Apr 17, 2024

Conversation

emontnemery
Copy link
Contributor

Proposed change

Use aiohttp-zlib-ng[isal], it's confirmed to work also on 32-bit machines

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@emontnemery emontnemery requested a review from a team as a code owner April 17, 2024 15:26
@home-assistant home-assistant bot added cla-signed core small-pr PRs with less than 30 lines. labels Apr 17, 2024
@emontnemery emontnemery merged commit e4280b2 into dev Apr 17, 2024
38 checks passed
@emontnemery emontnemery deleted the aiohttp-zlib-ng_isal branch April 17, 2024 15:57
@bdraco
Copy link
Member

bdraco commented Apr 17, 2024

Thanks. I'll kick off a nightly to make sure everything still works

@bdraco
Copy link
Member

bdraco commented Apr 17, 2024

It turns out constraints aren't allowed to have extras which makes the wheel builder fail

@bdraco
Copy link
Member

bdraco commented Apr 17, 2024

I think I can solve this by forking the package and releasing aiohttp-isal instead. I'll do that after lunch

@bdraco
Copy link
Member

bdraco commented Apr 17, 2024

#115777

@bdraco
Copy link
Member

bdraco commented Apr 17, 2024

Also the image builds were fine and the 32bit RPI works as expected

@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants