Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Wolf Smart Set Authentication and Session Management #115815

Merged
merged 11 commits into from
Apr 20, 2024

Conversation

mtielen
Copy link
Contributor

@mtielen mtielen commented Apr 18, 2024

Proposed change

Fix issues in the library to respect Wolf Authentication token lifetime and implement Session Management
https://github.com/janrothkegel/wolf-comm/releases/tag/0.0.7

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Fix in the library to respect Wolf API token lifetime and implement Session Management
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mtielen

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft April 18, 2024 18:44
@home-assistant
Copy link

Hey there @adamkrol93, mind taking a look at this pull request as it has been labeled with an integration (wolflink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of wolflink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign wolflink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run python -m script.gen_requirements_all to generate the necessary files as well.

@home-assistant home-assistant bot marked this pull request as draft April 18, 2024 19:12
@mtielen mtielen marked this pull request as ready for review April 18, 2024 22:16
@home-assistant home-assistant bot requested a review from jpbede April 18, 2024 22:16
Copy link
Contributor

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also provide a link to a changelog/diff of the library in the PR description.

Btw., looking at the GitHub repo, the 0.0.7 tag seems to be missing, although it's correctly uploaded to PyPi.
Fixed now.

@mtielen
Copy link
Contributor Author

mtielen commented Apr 19, 2024

Please also provide a link to a changelog/diff of the library in the PR description.

Btw., looking at the GitHub repo, the 0.0.7 tag seems to be missing, although it's correctly uploaded to PyPi.

Sorry it's my first time doing a PR. Thank you for the patience. I've added the link to the change notes on the tag to the description: https://github.com/janrothkegel/wolf-comm/releases/tag/0.0.7 Hope this gives everything need if not let me know.

@TheJulianJES
Copy link
Contributor

Please don't merge dev or rebase unless there are issues/test failures that need to be fixed by that.
CI needs to be rerun every time and it takes up time unnecessarily.

@@ -1,10 +1,10 @@
{
"domain": "wolflink",
"name": "Wolf SmartSet Service",
"codeowners": ["@adamkrol93"],
"codeowners": ["@adamkrol93", "@mtielen"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you intend to do more in this integration, otherwise it is not a requirement to add you here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpbede Yes as the current maintainer is not been reacting for 3 years and was talking to others how can improve this integration

@mtielen mtielen requested a review from jpbede April 20, 2024 11:00
Copy link
Member

@jpbede jpbede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for stepping up as a code owner ❤️

@jpbede jpbede merged commit d478b87 into home-assistant:dev Apr 20, 2024
38 checks passed
@mtielen mtielen deleted the Fix-Wolf-smartset branch April 20, 2024 21:52
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wolf Smart Set Integration for Home Assistant
3 participants