-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Wolf Smart Set Authentication and Session Management #115815
Conversation
Fix in the library to respect Wolf API token lifetime and implement Session Management
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @adamkrol93, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to run python -m script.gen_requirements_all
to generate the necessary files as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also provide a link to a changelog/diff of the library in the PR description.
Btw., looking at the GitHub repo, the 0.0.7 tag seems to be missing, although it's correctly uploaded to PyPi.
Fixed now.
Sorry it's my first time doing a PR. Thank you for the patience. I've added the link to the change notes on the tag to the description: https://github.com/janrothkegel/wolf-comm/releases/tag/0.0.7 Hope this gives everything need if not let me know. |
Please don't merge |
@@ -1,10 +1,10 @@ | |||
{ | |||
"domain": "wolflink", | |||
"name": "Wolf SmartSet Service", | |||
"codeowners": ["@adamkrol93"], | |||
"codeowners": ["@adamkrol93", "@mtielen"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you intend to do more in this integration, otherwise it is not a requirement to add you here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpbede Yes as the current maintainer is not been reacting for 3 years and was talking to others how can improve this integration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for stepping up as a code owner ❤️
Proposed change
Fix issues in the library to respect Wolf Authentication token lifetime and implement Session Management
https://github.com/janrothkegel/wolf-comm/releases/tag/0.0.7
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: