Add reconfigure step for vallox #115915
Add reconfigure step for vallox #115915
Conversation
|
Hey there @andre-richter, @viiru-, @yozik04, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
| "host": "[%key:common::config_flow::data::host%]" | ||
| }, | ||
| "data_description": { | ||
| "host": "Hostname or IP address of your Vallox device." |
There was a problem hiding this comment.
Is it possible to reuse this string from the user step?
There was a problem hiding this comment.
Yes, use [%key:component::vallox::config::step::user::data_description::state::host%] if I managed to type that correctly.
There was a problem hiding this comment.
Thanks! The translation compilation complained, but by removing ::state it worked ([%key:component::vallox::config::step::user::data_description::host%]`). 🥳
frenck
added
the
smash
| assert entry.data["host"] == "192.168.100.50" | ||
|
|
||
|
|
||
| async def test_reconfigure_host_to_invalid_ip_fails( |
There was a problem hiding this comment.
These tests handling exceptions and ending with FORM should continue so they either end with CREATE_ENTRY or ABORT.
Now we don't know if the user can continue and recover from the errors.
Proposed change
Add reconfigure config entry support to the Vallox integration.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: