Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ovoenergy to 2.0.0 #115921

Merged
merged 8 commits into from
Apr 22, 2024
Merged

Update ovoenergy to 2.0.0 #115921

merged 8 commits into from
Apr 22, 2024

Conversation

timmo001
Copy link
Contributor

Breaking change

Proposed change

Updates and fixes ovoenergy integration.

https://github.com/timmo001/ovoenergy/releases/tag/2.0.0
timmo001/ovoenergy@v1.2.0...2.0.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@timmo001 timmo001 marked this pull request as ready for review April 21, 2024 12:34
Copy link

@jakeherp jakeherp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, although not sure if my review means anything, as I am not a code owner 😄

Comment on lines 49 to 50
if custom_account := entry.data.get(CONF_ACCOUNT) is not None:
client.custom_account_id = custom_account
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move code outside of the try block that is not expected to raise aiohttp.ClientError

@timmo001 timmo001 requested a review from bdraco April 22, 2024 07:51
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @timmo001

@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Apr 22, 2024
@bdraco bdraco merged commit 6985d36 into home-assistant:dev Apr 22, 2024
38 checks passed
@timmo001 timmo001 deleted the ovoenergy-2.0.0 branch April 22, 2024 15:07
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OVO energy no longer connecting via integration
3 participants